build: fix ostk-core incompatible release #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 69.62% 69.62%
=======================================
Files 7 7
Lines 474 474
=======================================
Hits 330 330
Misses 144 144 ☔ View full report in Codecov by Sentry. |
| @@ -1,3 +1,3 @@ | |||
| # Apache License 2.0 | |||
|
|
|||
| open-space-toolkit-core~=2.1.0 | |||
| open-space-toolkit-core~=2.1 | |||
There was a problem hiding this comment.
I don't know if this is a good idea to do.
This will let the Python version get auto-bumped to 2.2, 2.3, etc. Since we only allow the CPP dependencies to bump patch versions, this could get us out of sync with CPP.
There was a problem hiding this comment.
Gotcha, so then we should allow all to be patch auto-updates
|
decided against pinning to the minor version so that it doesn't get out of sync with cpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the incompatible versions of ostk-core issue