Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simplify python installation #123

Merged
merged 7 commits into from
Jun 5, 2024
Merged

build: simplify python installation #123

merged 7 commits into from
Jun 5, 2024

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 requested a review from apaletta3 June 4, 2024 21:21
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff man, this makes the pipeline sooo much shorter :nerdsnipe:

going to trust that you know what you're doing with these changes, cause I've never touched python installs this far into the weeds ;)

Also, the base1, base2, and base3 images were only introduced to split up the build because it took over 6 hours which is the timeout for GH actions, so we can remove them and combine them back into one base image build now

@vishwa2710
Copy link
Contributor Author

going to trust that you know what you're doing with these changes, cause I've never touched python installs this far into the weeds ;)

Yeah for sure this is a good way of installing python, I've used it before in production successfully.

Also, the base1, base2, and base3 images were only introduced to split up the build because it took over 6 hours which is the timeout for GH actions, so we can remove them and combine them back into one base image build now

Agreed. I want to make sure it's stable and then in a follow up MR we can remove the splits.

@vishwa2710 vishwa2710 merged commit d7b344e into main Jun 5, 2024
5 checks passed
@vishwa2710 vishwa2710 deleted the vishwa2710-patch-1 branch June 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants