Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update build packages to not fail fast with matrix #98

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix: update build packages to not fail fast with matrix #98

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c086f5
fix: update build packages to not fail fast with matrix
apaletta3 Mar 18, 2024
49c487e
fix: tweak main running logic
apaletta3 Mar 18, 2024
a27383d
test: change fail fast
apaletta3 Mar 18, 2024
788c179
test: make changes to cpp and python packages
apaletta3 Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/build-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,29 +28,35 @@ jobs:
name: Build C++ Package
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
architecture: [amd64, arm64]
steps:
- name: Checkout Repository
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: actions/checkout@v3
with:
fetch-depth: 0
lfs: true
- name: Set up QEMU
- name: Set up QEMU for ARM64
if: matrix.architecture == 'arm64' && (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: docker/setup-qemu-action@v2
if: matrix.architecture == 'arm64' && github.event_name == 'push' && github.ref == 'refs/heads/main'
with:
platforms: arm64
- name: Login to DockerHub
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Pull Development Image
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
run: docker pull ${{ env.DOCKER_REGISTRY_PATH }}/${{ inputs.project_name }}-development:${{ inputs.project_version }}
- name: Build C++ Package
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
run: make build-packages-cpp-standalone PLATFORM=${{ matrix.architecture }}
- name: Upload C++ Package
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: actions/upload-artifact@v3
with:
name: cpp-package
Expand All @@ -60,29 +66,35 @@ jobs:
name: Build Python Package
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
architecture: [amd64, arm64]
steps:
- name: Checkout Repository
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: actions/checkout@v3
with:
fetch-depth: 0
lfs: true
- name: Set up QEMU
- name: Set up QEMU for ARM64
if: matrix.architecture == 'arm64' && (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: docker/setup-qemu-action@v2
if: matrix.architecture == 'arm64' && github.event_name == 'push' && github.ref == 'refs/heads/main'
with:
platforms: arm64
- name: Login to DockerHub
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Pull Development Image
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
run: docker pull ${{ env.DOCKER_REGISTRY_PATH }}/${{ inputs.project_name }}-development:${{ inputs.project_version }}
- name: Build Python Package
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
run: make build-packages-python-standalone PLATFORM=${{ matrix.architecture }}
- name: Upload Python Package
if: matrix.architecture != 'arm64' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
uses: actions/upload-artifact@v3
with:
name: python-package
Expand Down
Loading