Fuzz more intervals #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Too many lines of the same code. Is it possible to wrap it into |
|
I managed to reduce the amount of repetitions of that fuzzing clause down to just one clause with the same effect as before. Let me know if this seems better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #64, I added fuzzing, but this was only for Review-state cards that had been given a succesful rating of Hard, Good or Easy. I'm thinking it would also make sense to fuzz any interval that is not a user-defined learning or a relearning step.
In this PR, I made it so that the intervals of cards graduating from the re/learning steps now get fuzzed. Also, I made it so that Review-state cards, when rated Again with no relearning steps specified in the scheduler now also get fuzzed.
Let me know if this makes sense or if you have any questions 👍