Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small upkeeping #69

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Small upkeeping #69

merged 8 commits into from
Dec 13, 2024

Conversation

joshdavham
Copy link
Member

I went and made some minor changes to improve the repo a bit

  • Removed an unnecessary if-clause in Card.get_retrievability()
  • Explicitly defined the public API of the package using __any__ in __init__.py
  • Stopped ignoring ruff lint rules
  • Added a section linking to other fsrs implementations and srs python packatges at the end of the README
  • Other minor changes

Let me know if there're any questions/concerns 👍

L-M-Sherlock
L-M-Sherlock approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshdavham joshdavham added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit beb17cb Dec 13, 2024
5 checks passed
@joshdavham joshdavham deleted the small-upkeeping branch December 13, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshdavham @L-M-Sherlock