New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes type bug where difficulty became an int if it exceeded the thresholds #74

Merged

joshdavham merged 1 commit into open-spaced-repetition:main from TWAnthony:fix-difficulty-type-error

Dec 29, 2024

Contributor

TWAnthony commented Dec 29, 2024

The lines thresholding the difficulty between 1 and 10 were causing difficulty to become an integer, which then caused it to fail a type check later.

This change:

fixes the thresholding of difficulty to be between 1.0 and 10.0
adds a test of multiple successful reviews in quick succession to hit this threshold


          Fixes type bug where difficulty became an int if it exceeded the thre…

de50326

…sholds.

joshdavham approved these changes

View reviewed changes

Member

joshdavham left a comment

LGTM

Great catch! Thank you

joshdavham added this pull request to the merge queue

Merged via the queue into open-spaced-repetition:main with commit c97c0da

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet