-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add community values, improve code of conduct #1655
Add community values, improve code of conduct #1655
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor questions...
@jpkrohling I see that the prev copy I responded to on zoom is gone now... that's evolved into "respectfully disagree" ? Fine with me, just confirming.
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
I think I shared a gist on Zoom, which should still be available, but I do remember a written comment from you somewhere, I just can't find it now :-/ The version here is pretty much the same as the gist, split into the different documents as discussed during the GC call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I saw you asked for more mega-nitpicking 😅)
s/’/'/g
s/[“”]/"/g
nevermind TIL looks like we use both kinds of quotes quite (in)consistently in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For copyedits, and a link URL change suggestion, see inline comments. /cc @svrnm
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor comments to improve, but can merged and improved later.
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Thank you all for your comments! I'm merging this but will follow-up with @tigrannajaryan to work on the remaining item. Once that is clarified, I'll update the .github's version of the CoC, so that it's propagated to all repositories. |
observability space. That said, we expect community members to act in the best | ||
interests of the project. Each member’s priorities can (and should!) align with | ||
those of their employers so that the relationship is beneficial to all parties, | ||
but when acting as a maintainer or contributor to the project, community members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Change sentence to --> Each member’s priorities when acting as a maintainer or contributor for the project should represent the interests of the project and its community first before their other obligations (e.g. employer).
|
||
### Disclose potential conflicts of interest | ||
|
||
Even within the project, people might have different hats: a Collector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "might" to "may".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpkrohling @dyladan @trask - providing my suggestions. I see the PR has been merged but would like to see if these suggestions can be incorporated for further clarity. Thanks!
I sent #1855 to incorporate your comments |
This PR improves our code of conduct by stating how violations should be reported. It also adds a set of community values, showing what we expect from our community members when interacting with other members.
Signed-off-by: Juraci Paixão Kröhling [email protected]