Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the other repos we use publishToSonatype, i'm not sure what the differences is between that and publishMavenPublicationToSonatypeRepository #58

Closed
trask opened this issue Aug 31, 2023 · 2 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Aug 31, 2023

          in the other repos we use `publishToSonatype`, i'm not sure what the differences is between that and `publishMavenPublicationToSonatypeRepository`

also we don't seem to need -Pfinal=false in the other repos

Originally posted by @trask in #55 (comment)

@breedx-splk
Copy link
Contributor

I'm also not entirely sure, but I suspect it might be a difference between io.github.gradle-nexus.publish-plugin (https://github.com/gradle-nexus/publish-plugin) and maven-publish (https://docs.gradle.org/current/userguide/publishing_maven.html).

It looks like core and instrumentation use both....I don't understand why you'd want or need both...

@LikeTheSalad LikeTheSalad self-assigned this Sep 14, 2023
@LikeTheSalad
Copy link
Contributor

I'm also not entirely sure, but I suspect it might be a difference between io.github.gradle-nexus.publish-plugin (https://github.com/gradle-nexus/publish-plugin) and maven-publish (https://docs.gradle.org/current/userguide/publishing_maven.html).

It looks like core and instrumentation use both....I don't understand why you'd want or need both...

That's right they're different but they complement each other, the maven-publish plugin is Gradle's official way to set up and publish maven publications from a project, whereas io.github.gradle-nexus.publish-plugin takes the publications created by maven-publish and uploads them to maven central, automating the whole process of creating sonatype's staging "repo", then closing and releasing it too. The automation of these processes is the value provided by the nexus publish plugin, as they mention in maven central's doc where they talk about a plugin named "Gradle Nexus Staging Plugin" which was later deprecated in favor of the nexus publish plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants