Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshots with every merge to main #55

Merged

Conversation

breedx-splk
Copy link
Contributor

No description provided.

@breedx-splk breedx-splk requested a review from a team August 29, 2023 23:00
run: ./gradlew check
- name: publish snapshot
# final=false here means SNAPSHOT
run: ./gradlew publishMavenPublicationToSonatypeRepository -Prelease=true -Pfinal=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different from other Java repos due to something android specific?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly the same, we also use the same release plugin. Though we added these 2 flags, The release one is disabled by default, which means that only the main, unsigned .aar file will be built for dev purposes, whereas when it's enabled, the sources and javadoc artifacts will also be built and everything will be signed which makes the compilation take a bit longer so I think it's better to avoid that during development. And the final one is there to append SNAPSHOT to the version when disabled which is the default behaviour.

I'm not sure if that answers your question, so please let me know if there are any other details you'd like to know about it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask In the interest of progress, I'm going to merge this. I would like to better understand what the differences are that you are concerned about, so maybe we should open an issue? We do want consistency with the other java repos where it makes sense....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the other repos we use publishToSonatype, i'm not sure what the differences is between that and publishMavenPublicationToSonatypeRepository

also we don't seem to need -Pfinal=false in the other repos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #58

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of progress, I'm going to merge this

(btw I always support this)

Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants