Add demo app to CI builds #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #364 |
breedx-splk
commented
May 15, 2024
| -dontwarn com.fasterxml.jackson.core.JsonGenerator | ||
| -dontwarn com.google.auto.value.AutoValue$Builder | ||
| -dontwarn com.google.auto.value.AutoValue | ||
| -dontwarn com.google.auto.value.extension.memoized.Memoized |
There was a problem hiding this comment.
Minification was failing without this.
bidetofevil
pushed a commit
to bidetofevil/opentelemetry-android
that referenced
this pull request
May 18, 2024
* add demo app to ci builds * run from subdir * add jar * fixing build * need to touch the demo local.properties too * demo app gets its on version catalog * try and get renovate to chill out in the demo app project * add name * scale image down * more dep updates * remove root local.properties * add target sdk for app * simplify catalog
|
A little late to this but yeah this seems like the right move. The demo app can also pull in new versions of Android libraries that the agent doesn't need, so I think we'll get here eventually anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the reason for having the demo-app is to show features, but those features are meaningless if the usage of those doesn't work. We need to build the demo app with every PR and merge to main, in order to ensure compatibility.
I guess I should also mention that this provides the
demo-appwith its own version catalog. I think this is going to be required in order for us to version it separately (via renovate) without impacting the main build. It's some additional duplication, unfortunately, but I think it's needed given the multi-project approach we've chosen.