Actually call listeners #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bidetofevil
approved these changes
Jun 9, 2024
| @@ -348,4 +344,8 @@ private static ServiceManager createServiceManager(Object... services) { | |||
| private OpenTelemetryRumBuilder makeBuilder() { | |||
| return OpenTelemetryRum.builder(application, buildConfig()); | |||
| } | |||
|
|
|||
| private OtelRumConfig buildConfig() { | |||
There was a problem hiding this comment.
Since this is called in several tests and doesn't simply create a OtelRumConfig instance that just uses the defaults, should the method name indicate that?
LikeTheSalad
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #397, we introduced listeners who can get notified immediately after the otel sdk is created. This is used when creating the initialization events, but users also have the ability to add. Unfortunately, we forgot to actually call the listeners!