Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start AppStart span when installing activity lifecycle instrumentation #578

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instrumentation/activity/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ dependencies {
implementation(libs.androidx.core)
implementation(libs.androidx.navigation.fragment)
implementation(libs.opentelemetry.instrumentation.api)
testImplementation(libs.robolectric)
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class ActivityLifecycleInstrumentation : AndroidInstrumentation {
application: Application,
openTelemetryRum: OpenTelemetryRum,
) {
startupTimer.start(openTelemetryRum.openTelemetry.getTracer(INSTRUMENTATION_SCOPE))
application.registerActivityLifecycleCallbacks(startupTimer.createLifecycleCallback())
application.registerActivityLifecycleCallbacks(buildActivityLifecycleTracer(openTelemetryRum))
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.android.instrumentation.activity

import android.app.Application
import androidx.test.ext.junit.runners.AndroidJUnit4
import io.mockk.every
import io.mockk.mockk
import io.mockk.verify
import io.opentelemetry.android.OpenTelemetryRum
import io.opentelemetry.android.common.RumConstants
import io.opentelemetry.android.internal.services.ServiceManager.Companion
import io.opentelemetry.api.trace.Span
import io.opentelemetry.api.trace.SpanBuilder
import io.opentelemetry.api.trace.Tracer
import io.opentelemetry.sdk.OpenTelemetrySdk
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RuntimeEnvironment

@RunWith(AndroidJUnit4::class)
class ActivityInstrumentationTest {
private lateinit var activityLifecycleInstrumentation: ActivityLifecycleInstrumentation
private lateinit var application: Application
private lateinit var openTelemetryRum: OpenTelemetryRum
private lateinit var openTelemetry: OpenTelemetrySdk

@Before
fun setUp() {
application = RuntimeEnvironment.getApplication()
openTelemetry = mockk()
openTelemetryRum = mockk()
every { openTelemetryRum.openTelemetry }.returns(openTelemetry)
activityLifecycleInstrumentation = ActivityLifecycleInstrumentation()

Companion.initialize(application)
}

@Test
fun `Installing instrumentation starts AppStartupTimer`() {
val tracer: Tracer = mockk()
val startupSpanBuilder: SpanBuilder = mockk()
val startupSpan: Span = mockk()

every { openTelemetry.getTracer("io.opentelemetry.lifecycle") }.returns(tracer)
every { tracer.spanBuilder("AppStart") }.returns(startupSpanBuilder)
every { startupSpanBuilder.setStartTimestamp(any(), any()) }.returns(startupSpanBuilder)
every { startupSpanBuilder.setAttribute(RumConstants.START_TYPE_KEY, "cold") }.returns(
startupSpanBuilder,
)
every { startupSpanBuilder.startSpan() }.returns(startupSpan)

activityLifecycleInstrumentation.install(application, openTelemetryRum)

verify {
tracer.spanBuilder("AppStart")
}
verify {
startupSpanBuilder.setAttribute(RumConstants.START_TYPE_KEY, "cold")
}
verify {
startupSpanBuilder.startSpan()
}
}
}