Demo app: slow renders animation #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… effect after adding the comet book to cart. Added a few ways to make the animation slow render on purpose
marandaneto
approved these changes
Oct 15, 2024
|
I think this PR closes #608 or the slow render does not cause an ANR? |
breedx-splk
approved these changes
Oct 15, 2024
I believe that it does not cause an ANR. The ANR detector polls the main thread for activity and requires it to fail a certain number of times in a row. The slow rendering approaches here I think are not quite enough to trigger that. @magda-woj has a follow-up PR in the works to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to trigger slow rendering in the demo app.
SlowCometAnimation.ktcontains a jetpack compose animation of a "meteor shower" that's intentionally slowed down through delays, expensive drawing, and unnecessary random number generation. To see the animation, add any amount of The Comet Book (the last product on the product list) to the cart.