Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set conventions for java libs #63

Merged

Conversation

LikeTheSalad
Copy link
Contributor

Auto instrumentation modules/subprojects don't necessarily need to be of android library type, they can be plain java libs as well, so this PR adds plain java lib conventions and also gathers common conventions across android and java libs to avoid duplicating code.

@LikeTheSalad LikeTheSalad requested a review from a team September 3, 2023 14:32
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the improvement to modularization.

@breedx-splk breedx-splk merged commit c50f674 into open-telemetry:main Sep 5, 2023
2 checks passed
@LikeTheSalad LikeTheSalad deleted the set-conventions-for-java-libs branch September 11, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants