Adding okhttp autoinstrumentation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeTheSalad
commented
Sep 3, 2023
...ry/src/main/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttp3Singletons.java
Outdated
Show resolved
Hide resolved
…n' into adding-okhttp-autoinstrumentation
…n' into adding-okhttp-autoinstrumentation
…http-instrumentation
…aces created for okhtp
…http-instrumentation # Conflicts: # auto-instrumentation/okhttp/okhttp-3.0/library/src/main/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/internal/OkHttp3Singletons.java # gradle.properties
breedx-splk
reviewed
Sep 21, 2023
...in/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/internal/OkHttp3Singletons.java
Show resolved
Hide resolved
...n/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/otel.android-app-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
Co-authored-by: jason plumb <[email protected]>
Co-authored-by: jason plumb <[email protected]>
…o/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java Co-authored-by: jason plumb <[email protected]>
…o/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java Co-authored-by: jason plumb <[email protected]>
…o/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java Co-authored-by: jason plumb <[email protected]>
…o/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentationConfig.java Co-authored-by: jason plumb <[email protected]>
…n' into adding-okhttp-autoinstrumentation
breedx-splk
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first one to add support for automatic instrumentations of okhttp on Android. I'm planning to create a follow-up PR to address the outstanding items mentioned below to avoid making this PR too big.
Changes provided in this PR
Outstanding items