[connector/servicegraphconnector] Adds a new config option to enable messaging_system's metric generation

[t00mas]

Description:

• A new configuration option enable_messaging_system_latency_histogram is added. When enabled, it will generate a new histogram metric for nodes of connection_type=messaging_system, traces_service_graph_request_messaging_system_seconds

Link to tracking Issue: #30856

Testing:

• Adds a new unit test.

Documentation:

• Updated README

[mapno]

Maybe I'm missing something, but is this adding any new capabilities to the connector? It's simply adding a new metric with info already collected in other latency metrics. What problem is that solving?

[t00mas]

Maybe I'm missing something, but is this adding any new capabilities to the connector? It's simply adding a new metric with info already collected in other latency metrics. What problem is that solving?

All that's true, it's just optionally enabling the creation of a new metric dedicated to messaging systems. It's adapted from grafana/tempo#3453 and was suggested here #30856

[mapno]

Maybe I'm missing something, but is this adding any new capabilities to the connector? It's simply adding a new metric with info already collected in other latency metrics. What problem is that solving?

All that's true, it's just optionally enabling the creation of a new metric dedicated to messaging systems. It's adapted from grafana/tempo#3453 and was suggested here #30856

But that Tempo PR introduces a new way of measuring latency in messaging systems

My proposal is as follows:

Add a new latency histogram metric.
The calculation will involve subtracting the producer end_time from the consumer start_time.

IIUC, this one does not.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[Frapschen]

Can we implement this feature in the same way the current DB type span does?

[t00mas]

Sorry I left this unattended for a while, I took a break. I'll address the missing features for this PR ASAP.

Thanks for the reviews and comments!

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[JaredTan95]

@t00mas Hi, any updates? just friendly ping, take your time.

[t00mas]

@t00mas Hi, any updates? just friendly ping, take your time.

working on this this week, sorry for the delay

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.