[chore] add unit tests for the opampsupervisor #34812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
atoulme,
BinaryFissionGames,
evan-bradley and
tigrannajaryan
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
atoulme
reviewed
Aug 27, 2024
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
changed the title
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # cmd/opampsupervisor/supervisor/supervisor_test.go
BinaryFissionGames
suggested changes
Sep 26, 2024
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
No worries, and thanks a lot for the review! I have addressed all comments now (will keep an eye on the CI checks to make sure everything passes) |
# Conflicts: # cmd/opampsupervisor/supervisor/supervisor_test.go
evan-bradley
reviewed
Oct 2, 2024
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # cmd/opampsupervisor/supervisor/supervisor_test.go
Signed-off-by: Florian Bacher <[email protected]>
evan-bradley
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds more unit tests to the OpAmpSupervisor. For increasing the coverage further, and to simplify testing in general it might be worth looking into decoupling the supervisor more by introducing interfaces for e.g. the
Commanderand making use of a mocking framework (e.g. https://github.com/uber-go/mock which is already used in other modules within this repo).Link to tracking Issue: #24295
Testing: Added more unit tests to increase coverage