[sumconnector] Metrics to metrics and logs to metrics (tests / test data) #35434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
approved these changes
Sep 26, 2024
crobert-1
reviewed
Sep 26, 2024
|
@crobert-1 are any other approvals required? Or can you slap a ready to merge tag on this one? |
crobert-1
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds tests for metrics to metrics and logs to metrics
follows this pr: #34797
This is a lot of lines but it is mostly repetition and uses the same standard structure as the previously merged trace to metric tests.
I dont think this needs any changelog but let me know if it does for some reason! 😸
Link to tracking Issue: #32669
Testing:
Adds testing for metrics to metrics and logs to metrics using same methodology as previous PR
Documentation: No changes to docs. This is just tests.