simplify the signature of ProtoFromTraces as it never returns an error #35560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
a team,
dmitryax,
MovieStoreGuy and
yurishkuro
as code owners
atoulme
force-pushed
the
ProtoFromTracesError
branch
from
672d331
to
af7f9d3
Compare
github-actions
bot
requested review from
Aneurysm9,
dao-jun,
frzifus,
pavolloffay,
VihasMakwana and
yotamloe
atoulme
force-pushed
the
ProtoFromTracesError
branch
from
af7f9d3
to
efe76b1
Compare
VihasMakwana
approved these changes
Oct 2, 2024
yotamloe
approved these changes
Oct 7, 2024
songy23
approved these changes
Oct 7, 2024
dmitryax
approved these changes
Oct 8, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
ProtoFromTracesreturns an error but never sets it to a value besides nil. Removing it from the signature simplifies code downstream.