[chore] apply fieldalignment #37312
Open
[chore] apply fieldalignment #37312
+11
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
evan-bradley,
tigrannajaryan and
a team
as code owners
dmitryax
reviewed
Jan 19, 2025
Comment on lines
220
to
+221
| OutputPaths []string `mapstructure:"output_paths"` | ||
| Level zapcore.Level `mapstructure:"level"` |
There was a problem hiding this comment.
Is this done by a tool? Looks like it simply orders the fields by the size, but it doesn't matter in this case. It should be 32 bits in both cases. Curious if it can be configured to avoid changing fields if it's unnecessary?
I'm a bit concerned because it's technically a public API-breaking change for someone initializing it as Logs{level, paths} even if it's an anti-pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordering a few fields to apply fieldalignment.