[receiver/sqlquery] Decrease time of running integration tests #37624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitryax @crobert-1 |
crobert-1
added
the
ready to merge
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…telemetry#37624) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Improvements to integration test: 1. Reduced test execution time by changing the behavior from starting and shutting down the database container for each test case to starting the container **once** and then running all tests for the given engine. Gain ~22s: [Main job](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13077774968/job/36494091929): ``` DONE 47 tests, 8 skipped in 136.005s ``` [PR job](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13077857640/job/36494335331?pr=37624) ``` DONE 44 tests, 4 skipped in 114.374s ``` 2. Updated the Oracle container from [gvenzl/oracle-xe:21-slim-faststart](https://hub.docker.com/r/gvenzl/oracle-xe) to [gvenzl/oracle-free:slim-faststart](https://hub.docker.com/r/gvenzl/oracle-free), primarily to support ARM architecture. <!--Describe what testing was performed and which tests were added.--> #### Testing * Ran tests for Oracle and SQL Server locally to ensure they are not broken. Co-authored-by: Curtis Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to integration test:
Main job:
PR job
Testing