Remove unnecessary copy while decoding and constructing string #37734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
MovieStoreGuy,
a team,
djaglowski,
TylerHelmuth,
evan-bradley and
atoulme
as code owners
github-actions
bot
added
extension/encoding
internal/core
pkg/ottl
pkg/stanza
receiver/kafka
labels
github-actions
bot
requested review from
dao-jun,
dmitryax,
edmocosta,
kentquirk,
pavolloffay and
VihasMakwana
bogdandrutu
force-pushed
the
rm-unncessary-copy
branch
7 times, most recently
from
62f1762 to
ba0e4ee
Compare
atoulme
reviewed
Feb 6, 2025
atoulme
reviewed
Feb 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
djaglowski
approved these changes
Feb 6, 2025
bogdandrutu
force-pushed
the
rm-unncessary-copy
branch
2 times, most recently
from
c40b78d to
4450e14
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rm-unncessary-copy
branch
from
4450e14 to
9493b6f
Compare
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…telemetry#37734) Before (including copy of the bytes needed upstream): ``` goos: darwin goarch: arm64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/reader cpu: Apple M2 Max BenchmarkFileRead BenchmarkFileRead-12 6890 159408 ns/op 125802 B/op 132 allocs/op PASS ``` After ``` goos: darwin goarch: arm64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/reader cpu: Apple M2 Max BenchmarkFileRead BenchmarkFileRead-12 7662 154923 ns/op 121656 B/op 130 allocs/op PASS ``` Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (including copy of the bytes needed upstream):
After