Skip to content

Commit

Permalink
remove providers and converters from moduleinfo struct
Browse files Browse the repository at this point in the history
  • Loading branch information
jackgopack4 committed Feb 18, 2025
1 parent b482d6e commit 5631f36
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: otelcol, service
component: otelcol

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Converters are now available in the component command. Additionally, Converters and Providers are listed in ModuleInfos in service host implementation
note: Converters are now available in the `components` command.

# One or more tracking issues or pull requests related to the change
issues: [11900, 12372, 12375, 12385]
issues: [11900, 12385]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
subtext: Converters must now implement the "Type()" function to return type

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
Expand Down
2 changes: 0 additions & 2 deletions otelcol/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,6 @@ func (col *Collector) setupConfigurationComponents(ctx context.Context) error {
Exporter: buildModuleInfo(factories.ExporterModules),
Extension: buildModuleInfo(factories.ExtensionModules),
Connector: buildModuleInfo(factories.ConnectorModules),
Provider: buildModuleInfo(col.set.ProviderModules),
Converter: buildModuleInfo(col.set.ConverterModules),
},
AsyncErrorChannel: col.asyncErrorChannel,
LoggingOptions: col.set.LoggingOptions,
Expand Down
2 changes: 0 additions & 2 deletions service/internal/moduleinfo/moduleinfo.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@ type ModuleInfos struct {
Exporter map[component.Type]ModuleInfo
Extension map[component.Type]ModuleInfo
Connector map[component.Type]ModuleInfo
Provider map[component.Type]ModuleInfo
Converter map[component.Type]ModuleInfo
}

0 comments on commit 5631f36

Please sign in to comment.