Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Clean up unused variables #6100

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 24, 2025 11:19
@github-actions github-actions bot added documentation Documentation related pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 24, 2025
@CodeBlanch CodeBlanch changed the title remove un-used variables [repo] Clean up unused variables Jan 27, 2025
@CodeBlanch CodeBlanch merged commit c44984e into open-telemetry:main Jan 27, 2025
37 checks passed
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (e5a7095) to head (83e612a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6100      +/-   ##
==========================================
- Coverage   86.40%   86.40%   -0.01%     
==========================================
  Files         257      257              
  Lines       11649    11648       -1     
==========================================
- Hits        10065    10064       -1     
  Misses       1584     1584              
Files with missing lines Coverage Δ
...plementation/ZipkinActivityConversionExtensions.cs 95.76% <ø> (-0.04%) ⬇️

@SimonCropp SimonCropp deleted the remove-un-used-variables branch January 27, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants