Fixing bridge API bug #6113
Draft
Fixing bridge API bug #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
|
I think we need to agree on a direction via the issue before trying to fix something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issues #4433, #6109
Changes
This would change the behavior of the logging bridge API where body of the exported log would be set by the
Bodyof the emittedLogRecordData. I'm not sure if this change would be OK with you, but I don't see another way of directly setting both the body and the {OriginalFormat} attribute. This workaround is possible, but obviously not ideal. This scenario wasn't covered by unit tests, so I added one.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes