Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for Insecure #6658

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Conversation

mattsains
Copy link
Contributor

@mattsains mattsains commented Jan 21, 2025

@mattsains mattsains requested review from pellared and a team as code owners January 21, 2025 20:24
@github-actions github-actions bot requested a review from codeboten January 21, 2025 20:25
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (8129e89) to head (3210496).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6658   +/-   ##
=====================================
  Coverage   73.9%   73.9%           
=====================================
  Files        195     195           
  Lines      16671   16671           
=====================================
  Hits       12332   12332           
  Misses      3980    3980           
  Partials     359     359           
Files with missing lines Coverage Δ
config/v0.3.0/log.go 95.3% <100.0%> (ø)
config/v0.3.0/metric.go 89.0% <100.0%> (ø)
config/v0.3.0/trace.go 97.3% <100.0%> (ø)

... and 1 file with indirect coverage changes

@pellared
Copy link
Member

@codeboten, PTAL as a codeowner

config/v0.3.0/log.go Show resolved Hide resolved
@mattsains
Copy link
Contributor Author

@codeboten I think I need your approval to get this PR to merged

@dmathieu dmathieu merged commit beb885f into open-telemetry:main Feb 5, 2025
25 checks passed
@MrAlias MrAlias added this to the v1.35.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlpHTTPLogExporter, otlpGRPCLogExporter, etc do not support fields like OTLP.Certificate
5 participants