Skip to content

Commit

Permalink
[operator] Reject invalid/unknown properties using `additionalPropert…
Browse files Browse the repository at this point in the history
…ies` (#1065)

* [operator] Reject invalid/unknown properties using `additionalProperties: false`

This can catch misspellings like the one below, which I encountered when
using this Helm chart myself (but the previous validation did not catch it):

    Error: values don't meet the specifications of the schema(s) in the following chart(s):
    opentelemetry-operator:
    - (root): Additional property kubeRBACPRoxy is not allowed

* [operator] Bump operator minor version after validation update
  • Loading branch information
heyLu authored Mar 20, 2024
1 parent b969a4f commit 5712c12
Show file tree
Hide file tree
Showing 14 changed files with 64 additions and 19 deletions.
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-operator
version: 0.49.1
version: 0.50.0
description: OpenTelemetry Operator Helm chart for Kubernetes
type: application
home: https://opentelemetry.io/
Expand Down
5 changes: 5 additions & 0 deletions charts/opentelemetry-operator/UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Upgrade guidelines

## <0.50.0 to 0.50.0

Additional properties are not allowed anymore, so care must be taken that no old or misspelled ones are present anymore.
`helm show values open-telemetry/opentelemetry-operator --version 0.50.0` can be used to list the allowed values.

## <0.42.3 to 0.42.3

A type of flag `autoGenerateCert` has been changed, now it is an object with two attributes `enabled` and `recreate`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
annotations:
cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -91,7 +91,7 @@ metadata:
annotations:
cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -29,7 +29,7 @@ apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -213,7 +213,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -231,7 +231,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -25,7 +25,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: v1
kind: Service
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -31,7 +31,7 @@ apiVersion: v1
kind: Service
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: opentelemetry-operator
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: "example-opentelemetry-operator-cert-manager"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: "example-opentelemetry-operator-metrics"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -43,7 +43,7 @@ metadata:
name: "example-opentelemetry-operator-webhook"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.49.1
helm.sh/chart: opentelemetry-operator-0.50.0
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.95.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Loading

0 comments on commit 5712c12

Please sign in to comment.