Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI scenarios for eBPF Chart #964

Open
TylerHelmuth opened this issue Nov 20, 2023 · 6 comments
Open

Add CI scenarios for eBPF Chart #964

TylerHelmuth opened this issue Nov 20, 2023 · 6 comments
Labels
chart:ebpf Issues related to opentelemetry-ebpf helm chart good first issue Good for newcomers help wanted Extra attention is needed

Comments

@TylerHelmuth
Copy link
Member

Currently the ebpf chart has no CI tests. We should add a test for the default values.yaml at least, but it would be best if we could have more comprehensive coverage.
@TylerHelmuth TylerHelmuth added good first issue Good for newcomers help wanted Extra attention is needed chart:ebpf Issues related to opentelemetry-ebpf helm chart labels Nov 20, 2023
@TylerHelmuth
Copy link
Member Author

/cc @nicolastakashi

@hyfj44255
Copy link
Contributor

hyfj44255 commented May 28, 2024 •
edited
Loading

Hi @TylerHelmuth I would like to have a try if this is still needed, thanks!

@nicolastakashi
Copy link
Contributor

Hi @TylerHelmuth I would like to have a try if this is still needed, thanks!

Go for it @hyfj44255 🙏

@hyfj44255
Copy link
Contributor

hyfj44255 commented Jul 16, 2024 •
edited
Loading

Hi @TylerHelmuth and @nicolastakashi sorry for the delay ,you mentioned that "Currently the ebpf chart has no CI tests",by CI tests do you mean the tests that are ran by CT(helm/chart-testing) like the test cases under charts/opentelemetry-demo/ci ?

@nicolastakashi
Copy link
Contributor

Hey @hyfj44255, yes exactly like that

kayhern pushed a commit to fidelity-contributions/open-telemetry-opentelemetry-helm-charts that referenced this issue Aug 19, 2024
@hyfj44255
test: Add CI scenarios for eBPF Chart. open-telemetry#964
0a43de0 
Signed-off-by: Yang, Robin <[email protected]>
@hyfj44255 hyfj44255 mentioned this issue Aug 20, 2024
Merged
1 task
@hyfj44255
Copy link
Contributor

hyfj44255 commented Aug 20, 2024 •
edited
Loading

Hi @nicolastakashi I created a pr #1310 would it be ok if you take a look when you got chance? thanks

TylerHelmuth pushed a commit that referenced this issue Aug 27, 2024
@hyfj44255
test: Add CI scenarios for eBPF Chart. #964 (#1310)
7f64f3f
TylerHelmuth pushed a commit that referenced this issue Sep 25, 2024
@hyfj44255
fix: EBPF_NET_CRASH_METRIC_PORT container env in EBPF chart not being…
623c987 
… quoted issue. (#1347)

* test: Add CI scenarios for eBPF Chart. #964

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* fix: EBPF_NET_CRASH_METRIC_PORT env in ebpf chart not being quoted issue.

Signed-off-by: Yang, Robin <[email protected]>

* fix: EBPF_NET_CRASH_METRIC_PORT env in ebpf chart not being quoted issue.

Signed-off-by: Yang, Robin <[email protected]>

---------

Signed-off-by: Yang, Robin <[email protected]>
TylerHelmuth pushed a commit that referenced this issue Sep 26, 2024
@hyfj44255
feat: grant ebpf k8s collector job watching permission. (#1346)
b7407c4 
* test: Add CI scenarios for eBPF Chart. #964

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* test: Add CI scenarios for eBPF Chart. [issue-964]

Signed-off-by: Yang, Robin <[email protected]>

* fix: EBPF_NET_CRASH_METRIC_PORT env in ebpf chart not being quoted issue.

Signed-off-by: Yang, Robin <[email protected]>

* feat: grant ebpf k8s collector job watching permission.

Signed-off-by: Yang, Robin <[email protected]>

* feat: grant ebpf k8s collector job watching permission.

Signed-off-by: Yang, Robin <[email protected]>

* feat: grant ebpf k8s collector job watching permission.

Signed-off-by: Yang, Robin <[email protected]>

---------

Signed-off-by: Yang, Robin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chart:ebpf Issues related to opentelemetry-ebpf helm chart good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolastakashi @hyfj44255 @TylerHelmuth