test: Add CI scenarios for eBPF Chart. #964 #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang, Robin <[email protected]>
charts/opentelemetry-ebpf/templates/k8s-collector-deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
|
Hi @nicolastakashi I've updated the pr according to you suggestion would it be ok if you take a look again? |
TylerHelmuth
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the ebpf chart has no CI tests. we should add a test for the default values.yaml at least, but it would be best if we could have more comprehensive coverage.
Fixes #(issue)
#964
Type of change
How Has This Been Tested?
Go to Contrib repo root directory.
Create a kind cluster same as the one in repo's Github action
Run CT to preform the test