fix: Missing hostAliases implementation #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentMarchelli
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
|
|
JaredTan95
approved these changes
Feb 19, 2024
povilasv
approved these changes
Feb 19, 2024
LaurentMarchelli
force-pushed
the
hostAliases
branch
2 times, most recently
from
e680b9d
to
bf30bf0
Compare
LaurentMarchelli
changed the title
LaurentMarchelli
changed the title
LaurentMarchelli
force-pushed
the
hostAliases
branch
from
bf30bf0
to
1a37417
Compare
TylerHelmuth
approved these changes
Feb 21, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hostAliases customization added to otel collector helm chart, as requested by @ethernoy.
@dmitryax, would you please let me know if I have missed a step in the submission process.
Submitted as a patch, as the default configuration does not change any previously produced yaml.
Best regards,
Close #81