Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-collector] add persistentVolumeClaimRetentionPolicy in StatefulSet #1057

Merged
merged 11 commits into from
Mar 18, 2024

Conversation

lindeskar
Copy link
Contributor

@lindeskar lindeskar commented Mar 1, 2024

Fixes: #1056

  • Add persistentVolumeClaimRetentionPolicy in StatefulSet template
  • Add values to enable and customize persistentVolumeClaimRetentionPolicy
  • Add new example: "statefulset-with-pvc"

@lindeskar
Copy link
Contributor Author

@TylerHelmuth thanks for the approval! Let me know if there's anything else needed from me to merge (I don't have permission).

@TylerHelmuth
Copy link
Member

@dmitryax @povilasv please take a look.

@TylerHelmuth TylerHelmuth merged commit af4b111 into open-telemetry:main Mar 18, 2024
3 checks passed
@lindeskar lindeskar deleted the feat-pvc-retention-pol branch March 18, 2024 16:02
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
… StatefulSet (open-telemetry#1057)

* add persistentVolumeClaimRetentionPolicy

* add example values and rendered manifests

* add command to example README

* regenerate example

* bump version and generate examples

* remove semverCompare and add comment in values

* bump version and generate examples

* fix indentation of example values

* bump version and generate examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry-collector] StatefulSets do not delete PVCs when scaled or deleted
2 participants