Embed operator deployment in opentelemetry-kube-stack installation #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-helm-charts into 1079-make-bridge
…harts into 1076-embed-operator-deployment
Allex1
reviewed
Apr 24, 2024
| opentelemetry-operator: | ||
| # Field indicating whether the operator is enabled or not | ||
| # This is disabled for now while the chart is under development | ||
| enabled: false |
There was a problem hiding this comment.
Why not enable this by default ?
There was a problem hiding this comment.
i'm waiting to enable anything until #1081 is complete as that's when this chart will actually start doing stuff
Allex1
approved these changes
Apr 24, 2024
povilasv
approved these changes
Apr 25, 2024
TylerHelmuth
approved these changes
Apr 29, 2024
Co-authored-by: Tyler Helmuth <[email protected]>
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
…pen-telemetry#1147) * add bridge in * match name of bridge * updates from feedback * embed operator deployment in chart, readme * chart bump * Update charts/opentelemetry-kube-stack/values.yaml Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1076
This PR adds:
Note
(to be merged after #1138)