Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add TargetAllocator MTLS configuration to operator chart #1404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add TargetAllocator MTLS configuration to operator chart #1404

wants to merge 1 commit into from

Conversation

thefirstofthe300
Copy link
Contributor

The OTEL operator recently added support for using MTLS to secure the HTTP requests made from the collectors and the Target Allocator.

This PR adds support for enabling that feature gate using the directions found in the added documentation here.

@jaronoff97
Copy link
Contributor

it looks like something went very wrong with generating examples 😅

@thefirstofthe300
Copy link
Contributor Author

it looks like something went very wrong with generating examples 😅

I promise it wasn't me. 😅

If it makes any difference, I'm running on a linux laptop so I wonder if there's some sort of tool with a different API. I know I always get bit by sed when dealing with Mac vs Linux environments. Same goes for Docker bind mounts.

@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch from e355ec8 to 483d91b Compare November 1, 2024 01:03
@thefirstofthe300
Copy link
Contributor Author

Found the issue. Turns out that if values schema validation fails template rendering explodes.

@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch from 483d91b to 7cc5341 Compare November 1, 2024 01:05
jaronoff97
jaronoff97 reviewed Nov 1, 2024
View reviewed changes
charts/opentelemetry-operator/Chart.yaml Outdated Show resolved Hide resolved
charts/opentelemetry-operator/values.yaml Outdated Show resolved Hide resolved
@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch 4 times, most recently from c932063 to 7cabdb6 Compare November 4, 2024 20:20
@jaronoff97
Copy link
Contributor

also be sure to re-run make generate-examples CHARTS=opentelemetry-operator

@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch 4 times, most recently from 1ad8fc3 to 03d6db1 Compare November 4, 2024 20:35
@jaronoff97
Copy link
Contributor

hmmm it seems that there's a diff in the CRDs... not 100% sure why though. I wonder if it has to do with us checking the wrong version of them?

@thefirstofthe300
Copy link
Contributor Author

hmmm it seems that there's a diff in the CRDs... not 100% sure why though. I wonder if it has to do with us checking the wrong version of them?

I had to rerun the update CRD target and that seems to have cleared things up.

@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch from 03d6db1 to adc3225 Compare November 5, 2024 17:55
@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch 6 times, most recently from fec0bf4 to b8ca2a0 Compare November 6, 2024 18:13
TylerHelmuth
TylerHelmuth reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefirstofthe300 can you add a new example that uses the new map.

@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/add-mtls-to-operator branch from b8ca2a0 to 07ad113 Compare November 6, 2024 23:55
@thefirstofthe300
Copy link
Contributor Author

@thefirstofthe300 can you add a new example that uses the new map.

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@Allex1 Allex1 Awaiting requested review from Allex1 Allex1 is a code owner

@puckpuck puckpuck Awaiting requested review from puckpuck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thefirstofthe300 @jaronoff97 @TylerHelmuth