-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade operator version to 112 #1406
Conversation
|
||
# get-crd doesn't work on macos because of sed incompatibility | ||
# when upgrading the CRDs on MacOS, swap usage of get-crd to this macro | ||
define get-crd-macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to do this because sed for linux is incompatible with sed on macos 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time I bump the operator version I accidentally commit my gsed
changes lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah oop :( so this one is for us!
@@ -42,7 +42,7 @@ manager: | |||
tag: "" | |||
collectorImage: | |||
repository: "" | |||
tag: 0.111.0 | |||
tag: 0.112.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI there is a bug with collector 0.112.0 and the hostmetricsreceiver on k8s: open-telemetry/opentelemetry-collector-contrib#35990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh, i assume there won't be a patch for that right? Should i call this out in the release notes or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix will be in v0.113.0. Calling it out in the release notes feels right. The collector chart is gonna skip v0.112.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kk we may as well skip then too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a downside to updating this PR to use v0.113.0 of the collector when it releases this week?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, we can do that.
replaced by #1410 since @jaronoff97 is on PTO |
No description provided.