fix: #961 for cartservice disable reload on config change #962
Conversation
|
If you mean adding the env var to the Dockerfile, I think that could place an undue burden on developers contributing to this service if they are using development containers and desire the ability to reload on source code changes. |
There was a problem hiding this comment.
I'd like to get @puckpuck take on this as a default value for the chart. If this is not a widespread problem I'd prefer that it be handled by users via their values.yaml
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
We should take this discussion over to the Demo repo. We don't need to put it in the Dockerfile, but having it as part of docker-compose and Helm may make sense, which is how this gets deployed. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Prevent cart service from watching the file system for changes and reloading to resolve #961. See details and rationale in #961.