-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-knex): Support better-sqlite3 errors #2650
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
- Coverage 90.96% 90.96% -0.01%
==========================================
Files 172 172
Lines 8137 8134 -3
Branches 1649 1649
==========================================
- Hits 7402 7399 -3
Misses 735 735
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving since this was already approved at #2298
@pichlermarc can you merge this maybe? |
@pichlermarc or @trentm is there something blocking this getting merged and released? |
Which problem is this PR solving?
Resolves #2297
Short description of the changes
Make sure better-sqlite3 is supported by not assuming how the error constructor is set up. Adds test accordingly.
This is a rebase of #2298 by @AbhiPrasad with included review changes.