feat(collector): introduce new workflow to publish collector Lambda layer #1692
Conversation
serkan-ozal
force-pushed
the
feat/collector/custom-build-and-release
branch
from
ce74d1e to
ff1c49c
Compare
serkan-ozal
changed the title
| ClientIdList: | ||
| - "sts.amazonaws.com" | ||
| ThumbprintList: | ||
| - "ffffffffffffffffffffffffffffffffffffffff" |
There was a problem hiding this comment.
Should we consider using the latest published thumbprints here?
There was a problem hiding this comment.
It is not necessary.
Note that the thumbprint below has been set to all F's because the thumbprint is not used when authenticating token.actions.githubusercontent.com. This is a special case used only when GitHub's OIDC is authenticating to IAM. IAM uses its library of trusted CAs to authenticate. The value is still the API, so it must be specified.
There was a problem hiding this comment.
Nvm, this is new to me (used to break)
Note that the thumbprint below has been set to all F's because the thumbprint is not used when authenticating token.actions.githubusercontent.com. This is a special case used only when GitHub's OIDC is authenticating to IAM. IAM uses its library of trusted CAs to authenticate. The value is still the API, so it must be specified.
|
(Added the go label so we remember to group this in the collector release notes.) |
|
Fix for the failing job here: #1693 |
serkan-ozal
changed the title
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
serkan-ozal
force-pushed
the
feat/collector/custom-build-and-release
branch
from
96c97e2 to
bd9b36b
Compare
This PR introduces a new Github workflow (named
Publish Collector Lambda layer) to allow users publishing their own custom Lambda collector layers from their own forks into their own (or any target) AWS accounts.