-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Laravel] Allow Laravel 12 #333
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=========================================
Coverage 80.42% 80.42%
Complexity 1502 1502
=========================================
Files 128 128
Lines 6176 6176
=========================================
Hits 4967 4967
Misses 1209 1209 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
I propose we wait until #315 lands to ensure that the tests all pass under PHP 8.4. |
Hey @IonBazan 👋 Please could you merge main so the 8.4 pipeline could run for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IonBazan 👍
I've not had time to actually test Laravel 12 myself yet but, given the tests all pass, I would be happy to add my ✅
Have you managed to run this in a L12 test app?
Hey sorry, unfortunately I don't have any L12 app ready yet. I believe there weren't any major changes that would break current instrumentation though. |
Allows Laravel 12 to be installed with
open-telemetry/opentelemetry-auto-laravel