Skip to content

Commit

Permalink
remove todo for logging dropped attributes (#1485)
Browse files Browse the repository at this point in the history
this is already implemented for logs and traces as required by spec
  • Loading branch information
brettmc authored Jan 29, 2025
1 parent b24a30c commit e3f77b7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/SDK/Common/Attribute/AttributesBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ public function offsetSet($offset, $value): void
}

$this->attributes[$offset] = $this->normalizeValue($value);
//@todo "There SHOULD be a message printed in the SDK's log to indicate to the user that an attribute was
// discarded due to such a limit. To prevent excessive logging, the message MUST be printed at most
// once per <thing> (i.e., not per discarded attribute)."
}

/**
Expand Down

0 comments on commit e3f77b7

Please sign in to comment.