Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to phpunit 10 #1258

Merged
merged 2 commits into from
Mar 19, 2024
Merged

upgrade to phpunit 10 #1258

merged 2 commits into from
Mar 19, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Mar 15, 2024

  • ensure all data providers are static
  • work around phpunit no longer converting E_* to framework errors
  • abstract tests cannot end in Test
  • align Registry::registerLogRecordExporterFactory with other methods (throw TypeError insead of E_USER_WARNING)

@brettmc brettmc requested a review from a team March 15, 2024 02:12
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.87%. Comparing base (4cb0499) to head (f05832c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1258      +/-   ##
============================================
- Coverage     84.58%   83.87%   -0.71%     
  Complexity     2136     2136              
============================================
  Files           284      296      +12     
  Lines          6054     6104      +50     
============================================
- Hits           5121     5120       -1     
- Misses          933      984      +51     
Flag Coverage Δ
8.1 83.87% <100.00%> (-0.71%) ⬇️
8.2 83.87% <100.00%> (-0.71%) ⬇️
8.3 83.87% <100.00%> (-0.71%) ⬇️
8.4 83.87% <100.00%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/SDK/Registry.php 71.91% <100.00%> (+0.48%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb0499...f05832c. Read the comment docs.

@bobstrecansky bobstrecansky merged commit a1489d3 into open-telemetry:main Mar 19, 2024
8 of 9 checks passed
@brettmc brettmc mentioned this pull request Mar 20, 2024
@brettmc brettmc deleted the phpunit10 branch January 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants