Increase test coverage of instrumentation-aws-lambda #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Jul 31, 2024
...ion/opentelemetry-instrumentation-aws-lambda/tests/test_aws_lambda_instrumentation_manual.py
Outdated
Show resolved
Hide resolved
...ion/opentelemetry-instrumentation-aws-lambda/tests/test_aws_lambda_instrumentation_manual.py
Outdated
Show resolved
Hide resolved
...ation/opentelemetry-instrumentation-aws-lambda/tests/mocks/alb_conventional_headers_event.py
Show resolved
Hide resolved
...ion/opentelemetry-instrumentation-aws-lambda/tests/test_aws_lambda_instrumentation_manual.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Jul 31, 2024
...ion/opentelemetry-instrumentation-aws-lambda/tests/test_aws_lambda_instrumentation_manual.py
Outdated
Show resolved
Hide resolved
|
Feel free to enable maintainer editing so we can rebase for you :) |
jbfenton
force-pushed
the
increase_aws_lambda_test_coverage
branch
2 times, most recently
from
e39d67b
to
9b371f8
Compare
xrmx
approved these changes
Aug 5, 2024
...ion/opentelemetry-instrumentation-aws-lambda/tests/test_aws_lambda_instrumentation_manual.py
Outdated
Show resolved
Hide resolved
jbfenton
force-pushed
the
increase_aws_lambda_test_coverage
branch
from
9b371f8
to
b814355
Compare
emdneto
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split from: #2585
Increases the test coverage of instrumentation-aws-lambda in preparation for adding support for ALB events (and eventual refactoring)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
Changelogs have been updatedDocumentation has been updated