Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper script to run multiple tox environments #2763

Conversation

antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Jul 31, 2024

Description

This adds a simple helper script ./scripts/runtox.sh that allows people to run multiple tox environments with one call.

So ./scripts/runtox.sh py312 will run all tox environments having the string "py312" in their name.

This is helpful if you want to run all tox environments in one Python version, or run one environment in all Python versions. (like this: ./scripts/runtox.sh fastapi)

Contributed the same thing in opentelementry-python:
open-telemetry/opentelemetry-python#4095

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran it locally and it works (also we have something similar in Sentry, so I just copied it over)

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl
Copy link
Contributor

ocelotl commented Jul 31, 2024

You can do the same with tox -f 312. I am curious about the motivation behind this PR, in which scenario did you want to run all tests for a particular python version?

@xrmx
Copy link
Contributor

xrmx commented Jul 31, 2024

You can do the same with tox -f 312. I am curious about the motivation behind this PR, in which scenario did you want to run all tests for a particular python version?

I guess when adding support for a new python version

@lzchen
Copy link
Contributor

lzchen commented Jul 31, 2024

I guess when adding support for a new python version

This most of the time is done during implementation and in that case the existing build will detect errors for you. Not sure if that warrants a new tox helper script :|

@xrmx xrmx closed this Aug 1, 2024
@xrmx xrmx reopened this Aug 1, 2024
@antonpirker
Copy link
Contributor Author

Yes, my motivation was to easily run multiple environments at once, but as tox can do this (which I did not know) (see this comment here: open-telemetry/opentelemetry-python#4095 (review))

This PR is useless. Will close it. Sorry for the noise!

@antonpirker antonpirker closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants