Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen fastapi-slim version bound to be like the one for fastapi #2775

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

musicinmybrain
Copy link
Contributor

Description

See #2774, which this would fix, for a discussion of the issue.

If the original fastapi behavior is intended, then .0 should be dropped from the fastapi-slim version specification.

If the new fastapi-slim behavior is intended, then .0 should be added to the fastapi version specifications, and I’ll drop the FastAPI instrumentations from the Fedora package as I have needed to do for other instrumentations that require old versions of the instrumented libraries.

This PR implements the first option above.

Fixes #2774

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I did not run any tests.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated N/A, I think?
  • Unit tests have been added N/A
  • Documentation has been updated

@musicinmybrain musicinmybrain requested a review from a team August 3, 2024 17:43
Copy link
Contributor

@zhihali zhihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, when I add this version, the fastapi slim just have 0.111.0 and 0.111.1, I thought they gonna have a long time on 0.111.X, so use the ~=0.111.0, but they have the 0.112 in real quick😅

And I think changelog CI could be ignored, let's wait an approver mark it skip changelog

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 4, 2024
@lzchen lzchen merged commit 76919d3 into open-telemetry:main Aug 5, 2024
389 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastAPI SemVer bounds are inconsistent
4 participants