-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare asgi tests to support newer asgiref version #2778
Merged
lzchen
merged 5 commits into
open-telemetry:main
from
xrmx:fix-asgi-test-with-newer-asgiref
Aug 26, 2024
Merged
Prepare asgi tests to support newer asgiref version #2778
lzchen
merged 5 commits into
open-telemetry:main
from
xrmx:fix-asgi-test-with-newer-asgiref
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
changed the title
Fix asgi test swith newer asgiref
Fix asgi tests with newer asgiref
Aug 5, 2024
With the patches you made, we are now at:
Things are progressing in the right direction :) |
I won't be able to work on this for the next couple of weeks so please feel free to take over. |
It's totally fine. I have no knowledge in this project and these technologies yet. In the meantime, we've disabled the tests in Nix (NixOS/nixpkgs@b7ac9d1), so this thing can wait, no worries. |
xrmx
force-pushed
the
fix-asgi-test-with-newer-asgiref
branch
from
August 19, 2024 09:02
844e1a4
to
5ee216a
Compare
emdneto
changed the title
Fix asgi tests with newer asgiref
Prepare asgi tests to support newer asgiref version
Aug 23, 2024
emdneto
reviewed
Aug 23, 2024
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
xrmx
force-pushed
the
fix-asgi-test-with-newer-asgiref
branch
from
August 26, 2024 14:27
bddb238
to
357067a
Compare
emdneto
approved these changes
Aug 26, 2024
lzchen
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is trying to update the asgi tests, but this is draft because I'm not able to understand what's missing for middleware tests. It should be something trivial when interacting with the middleware because even basic tests are failing :)Requires open-telemetry/opentelemetry-python#4106
Fixes #2776
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.