Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.28.x-0.49bx] Add openai instrumentation to opentelemetry-bootstrap (#2996) #3010

Merged

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Nov 15, 2024

Clean cherry-pick of #2996 to the release/v1.28.x-0.49bx branch.

Part of open-telemetry/opentelemetry-python#4281

@aabmass aabmass requested a review from a team as a code owner November 15, 2024 03:08
@aabmass
Copy link
Member Author

aabmass commented Nov 15, 2024

Misc 0 / docs (pull_request) Failing after 35s

Docs build is failing because of a limitation with our automation. I am going to ignore for this release branch since it is usually skipped in the cherry pick workflow run by opentelemetrybot

@aabmass
Copy link
Member Author

aabmass commented Nov 15, 2024

@lzchen I had to run tox -e generate to fix CI as well 425b332. I think this is expected and I'm assuming the Prepare Release workflow will update it to the right version when I cut the patch release?

@lzchen
Copy link
Contributor

lzchen commented Nov 15, 2024

@lzchen I had to run tox -e generate to fix CI as well 425b332. I think this is expected and I'm assuming the Prepare Release workflow will update it to the right version when I cut the patch release?

Since openai instrumentation is released via a different workflow, it actually doesn't matter what the gen script changes the version to. In this case, it's actually "behind" on this release branch since the 2.0b0 release of openai instrumentation was already released after this release branch was created. I think you can just generate the code just to get builds to pass and it should be fine.

@aabmass aabmass merged commit d2e860c into open-telemetry:release/v1.28.x-0.49bx Nov 15, 2024
540 of 541 checks passed
@aabmass aabmass deleted the cherrypick-2996 branch November 15, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip generate-workflows To be used for release PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants