-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support logs with no body #4276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
This was referenced Nov 14, 2024
xrmx
approved these changes
Nov 14, 2024
tammy-baylis-swi
approved these changes
Nov 14, 2024
lzchen
approved these changes
Nov 14, 2024
aabmass
approved these changes
Nov 14, 2024
aabmass
pushed a commit
to aabmass/opentelemetry-python
that referenced
this pull request
Nov 14, 2024
aabmass
pushed a commit
to aabmass/opentelemetry-python
that referenced
this pull request
Nov 14, 2024
aabmass
added a commit
that referenced
this pull request
Nov 15, 2024
* Support logs with no body (#4276) * Move cherry-picked changelog entry into Unreleased section --------- Co-authored-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, if you send a log event without a body, code will crash like below. This allows a log record body to be
None
, avoiding this error.See discussion
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e test-py312-opentelemetry-exporter-otlp-proto-common
Does This PR Require a Contrib Repo Change?
Checklist: