[v1.28.x-0.49bx] Fix eachdist.py patch release to not add extra space #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make update-version-patch.sh executable
aabmass
force-pushed
the
patch-release-script-fix
branch
from
f48be9b
to
0d6fd62
Compare
aabmass
commented
Nov 15, 2024
| @@ -616,8 +616,9 @@ def update_patch_dependencies(targets, version, prev_version, packages): | |||
| operators_pattern = "|".join(re.escape(op) for op in operators) | |||
|
|
|||
| for pkg in packages: | |||
| search = rf"({basename(pkg)}[^,]*)(\s?({operators_pattern})\s?)(.*{prev_version})" | |||
| replace = r"\1\2 " + version | |||
| search = rf"({basename(pkg)}[^,]*?)(\s?({operators_pattern})\s?)(.*{prev_version})" | |||
There was a problem hiding this comment.
For anyone reading this, I changed [^,]* to be lazy -> [^,]*? so the second group captures the whitespace. Then I remove the extra whitespace in the replace string
aabmass
merged commit 099616a
into
open-telemetry:release/v1.28.x-0.49bx
352 checks passed
aabmass
added a commit
to aabmass/opentelemetry-python
that referenced
this pull request
Nov 15, 2024
…open-telemetry#4289) and make update-version-patch.sh executable
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make update-version-patch.sh executable