introducing uv in core #4451
Open
introducing uv in core #4451
+803
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
emdneto
commented
Feb 27, 2025
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
xrmx
approved these changes
Feb 28, 2025
aabmass
approved these changes
Feb 28, 2025
Kludex
approved these changes
Mar 6, 2025
| @@ -252,4 +252,4 @@ jobs: | |||
| run: pip install tox | |||
|
|
|||
| - name: Run tests | |||
| run: tox -e ruff | |||
| run: tox -e precommit | |||
There was a problem hiding this comment.
I do think it's weird to have a tox job called pre-commit instead of having the tox job be ruff, and not run pre-commit there.
There was a problem hiding this comment.
I think it's quite convenient as it runs everything we run locally with pre-commit 😅 Also, you can have the outcome in CI from both ruff commands. If we just use pure ruff command in tox, if the first command fails, the second one won't run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as open-telemetry/opentelemetry-python-contrib#3124
Also, I'm adding a new workflow called
precommitwhich now makes more sense. I'm keepingruffin tox just for convenience for contributors as requested here