Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rdkafka support to v0.19 including #1403

Merged

Conversation

smoke
Copy link
Contributor

@smoke smoke commented Feb 8, 2025

Up to version v0.19.0 it is expected that changes are only in method signatures, so try supporting up to that.

rel #1325

Up to version v0.20.0 it is expected that changes are only in
method signatures, so try supporting up to it

rel open-telemetry#1325
@smoke smoke force-pushed the feat/rdkafka-support-to-v0.19 branch from 573ad43 to e8e0e25 Compare February 8, 2025 15:06
@smoke smoke changed the title feat: rdkafka support to v0.19 feat: rdkafka support to v0.19 including Feb 8, 2025
@arielvalentin
Copy link
Collaborator

TY @smoke! I am looking for long term maintainers of this instrumentation since the original author is no longer able to commit to keeping it up to date.

Since you are one of the users of this instrumentation, would you be interested in taking over as the maintainer long term?

@smoke
Copy link
Contributor Author

smoke commented Feb 8, 2025

Hi @arielvalentin, thank you for this proposal!

I work with a project that has Kafka and Ruby as key technologies, while I am not a Ruby developer, I do care for OTel in the plethora of languages we use.

So I would love to contribute as much as possible!

@arielvalentin arielvalentin merged commit 2b1ce12 into open-telemetry:main Feb 8, 2025
59 of 60 checks passed
@github-actions github-actions bot mentioned this pull request Feb 8, 2025
@smoke smoke deleted the feat/rdkafka-support-to-v0.19 branch February 9, 2025 12:56
@smoke
Copy link
Contributor Author

smoke commented Feb 9, 2025

@arielvalentin what is the procedure to become a maintainer?

@arielvalentin
Copy link
Collaborator

It's a little different for single gems than taking in a full fledge CNCF role. I'll update codeowners and mention you if and when someone opens a pull request related to rdkafka.

If you'd like to work towards becoming a Ruby Contrib Maintainer for all gems in this repo the requirements can be found in the community repository.

@smoke
Copy link
Contributor Author

smoke commented Feb 9, 2025

Let's start small!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants