Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update out-of-date google-protobuf-any #1816

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented Feb 19, 2025

Closes: #1814

This issue won't cause any major breakdown since it's only for logging the error message.

If the change is valid, then it needs to be updated for all exporters.

@kaylareopelle
Copy link
Contributor

Do we need to update the min version of the protobuf dependencies for the gems too?

@xuan-cao-swi
Copy link
Contributor Author

Do we need to update the min version of the protobuf dependencies for the gems too?

I'm not very familiar with protobuf but I can share what I found:

I don't think we need to update protobuf dependencies (well_known_types.rb file's last commit is 2 years ago); I think that's just an edge case that was missed.

By looking at the well_known_types.rb, it seems like we can access type_name ? But strangely it returns no method when access it.

The type_name seems also derived from type_url (e.g. type_url split), so I think it's safe to use type_url split in our implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricsReporter: possible outdate protobuf datatype
2 participants